]> www.infradead.org Git - users/jedix/linux-maple.git/commit
irqchip/gic-v2m: Prevent use after free of gicv2m_get_fwnode()
authorSuzuki K Poulose <suzuki.poulose@arm.com>
Tue, 22 Apr 2025 16:16:16 +0000 (17:16 +0100)
committerIngo Molnar <mingo@kernel.org>
Sat, 26 Apr 2025 08:17:24 +0000 (10:17 +0200)
commit3318dc299b072a0511d6dfd8367f3304fb6d9827
tree7c9544ee7d852b9c47c9ce19384498f045218067
parent9d7a0577c9db35c4cc52db90bc415ea248446472
irqchip/gic-v2m: Prevent use after free of gicv2m_get_fwnode()

With ACPI in place, gicv2m_get_fwnode() is registered with the pci
subsystem as pci_msi_get_fwnode_cb(), which may get invoked at runtime
during a PCI host bridge probe. But, the call back is wrongly marked as
__init, causing it to be freed, while being registered with the PCI
subsystem and could trigger:

 Unable to handle kernel paging request at virtual address ffff8000816c0400
  gicv2m_get_fwnode+0x0/0x58 (P)
  pci_set_bus_msi_domain+0x74/0x88
  pci_register_host_bridge+0x194/0x548

This is easily reproducible on a Juno board with ACPI boot.

Retain the function for later use.

Fixes: 0644b3daca28 ("irqchip/gic-v2m: acpi: Introducing GICv2m ACPI support")
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Marc Zyngier <maz@kernel.org>
Cc: stable@vger.kernel.org
drivers/irqchip/irq-gic-v2m.c