]> www.infradead.org Git - users/jedix/linux-maple.git/commit
spi: cadence-qspi: fix pointer reference in runtime PM hooks
authorThéo Lebrun <theo.lebrun@bootlin.com>
Thu, 22 Feb 2024 10:12:29 +0000 (11:12 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 22 Feb 2024 12:25:07 +0000 (12:25 +0000)
commit32ce3bb57b6b402de2aec1012511e7ac4e7449dc
tree5691c235082e1ad5f11388c1ad7014eb3d40efe0
parent269e31aecdd0b70f53a05def79480f15cbcc0fd6
spi: cadence-qspi: fix pointer reference in runtime PM hooks

dev_get_drvdata() gets used to acquire the pointer to cqspi and the SPI
controller. Neither embed the other; this lead to memory corruption.

On a given platform (Mobileye EyeQ5) the memory corruption is hidden
inside cqspi->f_pdata. Also, this uninitialised memory is used as a
mutex (ctlr->bus_lock_mutex) by spi_controller_suspend().

Fixes: 2087e85bb66e ("spi: cadence-quadspi: fix suspend-resume implementations")
Reviewed-by: Dhruva Gole <d-gole@ti.com>
Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
Link: https://msgid.link/r/20240222-cdns-qspi-pm-fix-v4-1-6b6af8bcbf59@bootlin.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-cadence-quadspi.c