]> www.infradead.org Git - users/hch/uuid.git/commit
phy: exynos5-usbdrd: fix definition of EXYNOS5_FSEL_26MHZ
authorAndré Draszik <andre.draszik@linaro.org>
Tue, 7 May 2024 14:14:47 +0000 (15:14 +0100)
committerVinod Koul <vkoul@kernel.org>
Wed, 12 Jun 2024 11:17:29 +0000 (16:47 +0530)
commit32b2495e731f2a56118034e9c665e6fe56bbfe3a
treed20e9ab90822fbe8e022496fb5fcf4f6e632d641
parentf2b6fc4d5c9793c556412e9a8ac122670a0d8dcb
phy: exynos5-usbdrd: fix definition of EXYNOS5_FSEL_26MHZ

Using 0x82 seems odd, where everything else is just a sequence.

On E850, this macro isn't used (as a register value), only to assign
its value to the 'extrefclk' variable, which is otherwise unused on
that platform. Older platforms don't appear to support 26MHz in the
first place (since this macro was added for E850).

Furthermore, the downstream driver uses 0x82 to denote
USBPHY_REFCLK_DIFF_26MHZ (whatever that means exactly), but for all the
other values we match downstream's non-DIFF macros.

Update to avoid confusion. No functional change intended.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
Reviewed-by: Peter Griffin <peter.griffin@linaro.org>
Link: https://lore.kernel.org/r/20240507-samsung-usb-phy-fixes-v1-4-4ccba5afa7cc@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/samsung/phy-exynos5-usbdrd.c