]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/i915/display: Use explicit base values in POWER_DOMAIN_*() macros
authorGustavo Sousa <gustavo.sousa@intel.com>
Thu, 27 Feb 2025 21:09:12 +0000 (18:09 -0300)
committerGustavo Sousa <gustavo.sousa@intel.com>
Fri, 28 Feb 2025 16:30:57 +0000 (13:30 -0300)
commit322ec93e9081d717fbc02c14fe80f754709e8b9c
tree7eef9fca31f08939595ac101b65b548c2ab3ecef
parent2c2e7170a750506ed9e1d28e225b647a6563fb3c
drm/i915/display: Use explicit base values in POWER_DOMAIN_*() macros

Although we have comments in intel_display_limits.h saying that the
code expects PIPE_A and TRANSCODER_A to be zero, it doesn't hurt to add
them as explicit base values for calculating the power domain offset in
POWER_DOMAIN_*() macros.

On the plus side, we have that this:

 * Fixes a warning reported by kernel test robot <lkp@intel.com>
   about doing arithmetic with two different enum types.
 * Makes the code arguably more robust (in the unlikely event of those
   bases becoming non-zero).

v2:
  - Prefer using explicit base values instead of simply casting the
    macro argument to int. (Ville)
  - Update commit message to match the new approach (for reference, the
    old message subject was "drm/i915/display: Use explicit cast in
    POWER_DOMAIN_*() macros").

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202502120809.XfmcqkBD-lkp@intel.com/
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250227-improve-type-safey-power-domain-macros-v3-1-b6eaa00f9c33@intel.com
Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
drivers/gpu/drm/i915/display/intel_display_power.h