]> www.infradead.org Git - users/jedix/linux-maple.git/commit
usb: typec: tcpm/tcpci_maxim: fix irq wake usage
authorAndré Draszik <andre.draszik@linaro.org>
Mon, 7 Jul 2025 10:50:27 +0000 (11:50 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 15 Jul 2025 17:49:57 +0000 (19:49 +0200)
commit31611223fb34a3e9320cdfc4f4395072a13ea78e
tree2ba002556616a2b401b9722cce57c21d3c269e88
parenta1abefe004da0f9a2d65637f40659241fe12c6ac
usb: typec: tcpm/tcpci_maxim: fix irq wake usage

This driver calls enable_irq_wake() during probe() unconditionally, and
never issues the required corresponding disable_irq_wake() to disable
hardware interrupt wakeup signals.

Additionally, whether or not a device should wake-up the system is
meant to be a policy decision based on sysfs (.../power/wakeup) in the
first place.

Update the driver to use the standard approach to enable/disable IRQ
wake during the suspend/resume callbacks. This solves both issues
described above.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
Reviewed-by: Badhri Jagan Sridharan <badhri@google.com>
Link: https://lore.kernel.org/r/20250707-max77759-irq-wake-v1-1-d367f633e4bc@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/tcpm/tcpci_maxim_core.c