]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ASoC: soc-pcm: don't use soc_pcm_ret() on .prepare callback
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Fri, 13 Dec 2024 01:21:10 +0000 (01:21 +0000)
committerMark Brown <broonie@kernel.org>
Mon, 16 Dec 2024 12:31:28 +0000 (12:31 +0000)
commit301c26a018acb94dd537a4418cefa0f654500c6f
tree2f9c94d840cf80e15fa94bee536dd355df40224e
parent539a3f0c99cf62c61edc37a8f88e3073119ae852
ASoC: soc-pcm: don't use soc_pcm_ret() on .prepare callback

commit 1f5664351410 ("ASoC: lower "no backend DAIs enabled for ... Port"
log severity") ignores -EINVAL error message on common soc_pcm_ret().
It is used from many functions, ignoring -EINVAL is over-kill.

The reason why -EINVAL was ignored was it really should only be used
upon invalid parameters coming from userspace and in that case we don't
want to log an error since we do not want to give userspace a way to do
a denial-of-service attack on the syslog / diskspace.

So don't use soc_pcm_ret() on .prepare callback is better idea.

Link: https://lore.kernel.org/r/87v7vptzap.wl-kuninori.morimoto.gx@renesas.com
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://patch.msgid.link/87bjxg8jju.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-pcm.c