]> www.infradead.org Git - users/dwmw2/linux.git/commit
kernel/module: Fix mem leak in module_add_modinfo_attrs
authorYueHaibing <yuehaibing@huawei.com>
Tue, 11 Jun 2019 15:00:07 +0000 (23:00 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 19 Sep 2019 07:11:01 +0000 (09:11 +0200)
commit2fd4aaaf615d117ef28ff619046302ff2d65ab0c
treecfbf554fceb0e315a0522458371859ef5f6041dd
parenta9ce57d57155b21cc667d26f737231b420232a5c
kernel/module: Fix mem leak in module_add_modinfo_attrs

commit bc6f2a757d525e001268c3658bd88822e768f8db upstream.

In module_add_modinfo_attrs if sysfs_create_file
fails, we forget to free allocated modinfo_attrs
and roll back the sysfs files.

Fixes: 03e88ae1b13d ("[PATCH] fix module sysfs files reference counting")
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Jessica Yu <jeyu@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/module.c