]> www.infradead.org Git - users/jedix/linux-maple.git/commit
libceph: don't bail early from try_read() when skipping a message
authorIlya Dryomov <idryomov@gmail.com>
Wed, 17 Feb 2016 19:04:08 +0000 (20:04 +0100)
committerChuck Anderson <chuck.anderson@oracle.com>
Thu, 26 May 2016 22:45:28 +0000 (15:45 -0700)
commit2f75903f9a65689eb91acbb0e4fdfcb8b8470da8
tree75b47ea373da0b4f924d5bfce64dc1f946566f7f
parenta22cd61a29bbcfac02f58def1d588049d599f87e
libceph: don't bail early from try_read() when skipping a message

Orabug: 23330968

[ Upstream commit e7a88e82fe380459b864e05b372638aeacb0f52d ]

The contract between try_read() and try_write() is that when called
each processes as much data as possible.  When instructed by osd_client
to skip a message, try_read() is violating this contract by returning
after receiving and discarding a single message instead of checking for
more.  try_write() then gets a chance to write out more requests,
generating more replies/skips for try_read() to handle, forcing the
messenger into a starvation loop.

Cc: stable@vger.kernel.org # 3.10+
Reported-by: Varada Kari <Varada.Kari@sandisk.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Tested-by: Varada Kari <Varada.Kari@sandisk.com>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
(cherry picked from commit 265570c9977908479db74fd07b710ec5d5c96e12)

Signed-off-by: Dan Duval <dan.duval@oracle.com>
net/ceph/messenger.c