]> www.infradead.org Git - users/dwmw2/linux.git/commit
ALSA: usb: Fix UBSAN warning in parse_audio_unit()
authorTakashi Iwai <tiwai@suse.de>
Mon, 15 Jul 2024 12:35:54 +0000 (14:35 +0200)
committerTakashi Iwai <tiwai@suse.de>
Mon, 15 Jul 2024 14:06:09 +0000 (16:06 +0200)
commit2f38cf730caedaeacdefb7ff35b0a3c1168117f9
treec7e89afb408dbed7fc07a8f2b0b6be0f20d63198
parent5fa87a081b2d633b944d5a93f5767623ef2a961d
ALSA: usb: Fix UBSAN warning in parse_audio_unit()

A malformed USB descriptor may pass the lengthy mixer description with
a lot of channels, and this may overflow the 32bit integer shift
size, as caught by syzbot UBSAN test.  Although this won't cause any
real trouble, it's better to address.

This patch introduces a sanity check of the number of channels to bail
out the parsing when too many channels are found.

Reported-by: syzbot+78d5b129a762182225aa@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/0000000000000adac5061d3c7355@google.com
Link: https://patch.msgid.link/20240715123619.26612-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/mixer.c