]> www.infradead.org Git - users/jedix/linux-maple.git/commit
qed: put cond_resched() in qed_dmae_operation_wait()
authorMichal Schmidt <mschmidt@redhat.com>
Mon, 30 Sep 2024 20:13:07 +0000 (22:13 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 4 Oct 2024 16:25:15 +0000 (09:25 -0700)
commit2efeaf1d2a13f4b7419d60cd145ac84a3c151214
tree4dee535f7d2fb7e15519285e11a0326a98337866
parentcf54ae6b59203bea4f4c749043fa57a58d279e38
qed: put cond_resched() in qed_dmae_operation_wait()

It is OK to sleep in qed_dmae_operation_wait, because it is called only
in process context, while holding p_hwfn->dmae_info.mutex from one of
the qed_dmae_{host,grc}2{host,grc} functions.
The udelay(DMAE_MIN_WAIT_TIME=2) in the function is too short to replace
with usleep_range, but at least it's a suitable point for checking if we
should give up the CPU with cond_resched().

This lowers the latency caused by 'ethtool -d' from 10 ms to less than
2 ms on my test system with voluntary preemption.

Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Link: https://patch.msgid.link/20240930201307.330692-5-mschmidt@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/qlogic/qed/qed_hw.c