]> www.infradead.org Git - users/jedix/linux-maple.git/commit
PCI: brcmstb: Fix missing of_node_put() in brcm_pcie_probe()
authorStanimir Varbanov <svarbanov@suse.de>
Wed, 22 Jan 2025 22:29:55 +0000 (00:29 +0200)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Mon, 24 Feb 2025 18:50:54 +0000 (18:50 +0000)
commit2df181e1aea4628a8fd257f866026625d0519627
tree533be96b3d30eba5d82b4825404add81f8f5083a
parent2014c95afecee3e76ca4a56956a936e23283f05b
PCI: brcmstb: Fix missing of_node_put() in brcm_pcie_probe()

A call to of_parse_phandle() is incrementing the refcount, and as such,
the of_node_put() must be called when the reference is no longer needed.

Thus, refactor the existing code and add a missing of_node_put() call
following the check to ensure that "msi_np" matches "pcie->np" and after
MSI initialization, but only if the MSI support is enabled system-wide.

Cc: stable@vger.kernel.org # v5.10+
Fixes: 40ca1bf580ef ("PCI: brcmstb: Add MSI support")
Signed-off-by: Stanimir Varbanov <svarbanov@suse.de>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20250122222955.1752778-1-svarbanov@suse.de
[kwilczynski: commit log]
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
drivers/pci/controller/pcie-brcmstb.c