]> www.infradead.org Git - users/jedix/linux-maple.git/commit
wifi: ath12k: avoid double SW2HW_MACID conversion
authorKarthikeyan Periyasamy <quic_periyasa@quicinc.com>
Mon, 6 May 2024 17:30:17 +0000 (23:00 +0530)
committerKalle Valo <quic_kvalo@quicinc.com>
Mon, 13 May 2024 14:12:53 +0000 (17:12 +0300)
commit2db7a82fd150193849d04592e205b3d178207840
treed1fe4d39177bdb9e91ad64d6ce6e712deebc42a6
parent199f149e97dc7be80e5eed4b232529c1d1aa8055
wifi: ath12k: avoid double SW2HW_MACID conversion

Currently, ath12k_wmi_pdev_dma_ring_cfg() fails due to an invalid pdev_id
parameter passed to the WMI_PDEV_DMA_RING_CFG_REQ_CMDID WMI command. This
invalid pdev_id is caused by a double conversion of the MAC ID. Since the
the caller of ath12k_wmi_pdev_dma_ring_cfg() already performs the MAC ID
conversion, it is unnecessary to do it again within the function. To fix
this, remove the software (SW) to hardware (HW) MAC ID conversion from
ath12k_wmi_pdev_dma_ring_cfg() to avoid this redundant conversion.

Found in code review.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1

Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://msgid.link/20240506173017.597715-1-quic_periyasa@quicinc.com
drivers/net/wireless/ath/ath12k/wmi.c