]> www.infradead.org Git - users/jedix/linux-maple.git/commit
mfd: sm501: Switch to BIT() to mitigate integer overflows
authorNikita Zhandarovich <n.zhandarovich@fintech.ru>
Wed, 15 Jan 2025 17:12:06 +0000 (09:12 -0800)
committerLee Jones <lee@kernel.org>
Fri, 14 Mar 2025 08:59:05 +0000 (08:59 +0000)
commit2d8cb9ffe18c2f1e5bd07a19cbce85b26c1d0cf0
tree5e22f88236c1e98336a305b416b0d06c410e5aa3
parent9675c059e489ced89aa894214afdaa2605bc9559
mfd: sm501: Switch to BIT() to mitigate integer overflows

If offset end up being high enough, right hand expression in functions
like sm501_gpio_set() shifted left for that number of bits, may
not fit in int type.

Just in case, fix that by using BIT() both as an option safe from
overflow issues and to make this step look similar to other gpio
drivers.

Found by Linux Verification Center (linuxtesting.org) with static
analysis tool SVACE.

Fixes: f61be273d369 ("sm501: add gpiolib support")
Signed-off-by: Nikita Zhandarovich <n.zhandarovich@fintech.ru>
Link: https://lore.kernel.org/r/20250115171206.20308-1-n.zhandarovich@fintech.ru
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/sm501.c