]> www.infradead.org Git - users/jedix/linux-maple.git/commit
nvme-tcp: fix link failure for TCP auth
authorArnd Bergmann <arnd@arndb.de>
Mon, 9 Sep 2024 20:21:09 +0000 (20:21 +0000)
committerKeith Busch <kbusch@kernel.org>
Tue, 10 Sep 2024 14:41:07 +0000 (07:41 -0700)
commit2d5a333e09c388189238291577e443221baacba0
tree8e8395d551fdf5868065365b13dd0843ba73a47f
parent389e72c5d1efcfd3962d29624c1b78cfa002911e
nvme-tcp: fix link failure for TCP auth

The nvme fabric driver calls the nvme_tls_key_lookup() function from
nvmf_parse_key() when the keyring is enabled, but this is broken in a
configuration with CONFIG_NVME_FABRICS=y and CONFIG_NVME_TCP=m because
this leads to the function definition being in a loadable module:

x86_64-linux-ld: vmlinux.o: in function `nvmf_parse_key':
fabrics.c:(.text+0xb1bdec): undefined reference to `nvme_tls_key_lookup'

Move the 'select' up to CONFIG_NVME_FABRICS itself to force this
part to be built-in as well if needed.

Fixes: 5bc46b49c828 ("nvme-tcp: check for invalidated or revoked key")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/host/Kconfig