]> www.infradead.org Git - users/jedix/linux-maple.git/commit
IB/srpt: Simplify srpt_handle_tsk_mgmt()
authorBart Van Assche <bart.vanassche@sandisk.com>
Thu, 11 Feb 2016 19:03:09 +0000 (11:03 -0800)
committerChuck Anderson <chuck.anderson@oracle.com>
Thu, 26 May 2016 22:46:12 +0000 (15:46 -0700)
commit2cef2086e416885605f5808d4a4b90d74544a199
treed0c04c6984c81053301f4bd6bcc2a30a2e149ac9
parentdd0023c7e9d01028d45334473b5a9e8f7292c09d
IB/srpt: Simplify srpt_handle_tsk_mgmt()

Orabug: 23331076

[ Upstream commit 51093254bf879bc9ce96590400a87897c7498463 ]

Let the target core check task existence instead of the SRP target
driver. Additionally, let the target core check the validity of the
task management request instead of the ib_srpt driver.

This patch fixes the following kernel crash:

BUG: unable to handle kernel NULL pointer dereference at 0000000000000001
IP: [<ffffffffa0565f37>] srpt_handle_new_iu+0x6d7/0x790 [ib_srpt]
Oops: 0002 [#1] SMP
Call Trace:
 [<ffffffffa05660ce>] srpt_process_completion+0xde/0x570 [ib_srpt]
 [<ffffffffa056669f>] srpt_compl_thread+0x13f/0x160 [ib_srpt]
 [<ffffffff8109726f>] kthread+0xcf/0xe0
 [<ffffffff81613cfc>] ret_from_fork+0x7c/0xb0

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Fixes: 3e4f574857ee ("ib_srpt: Convert TMR path to target_submit_tmr")
Tested-by: Alex Estrin <alex.estrin@intel.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: Nicholas Bellinger <nab@linux-iscsi.org>
Cc: Sagi Grimberg <sagig@mellanox.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
(cherry picked from commit 179e72b561d3d331c850e1a5779688d7a7de5246)

Signed-off-by: Dan Duval <dan.duval@oracle.com>
drivers/infiniband/ulp/srpt/ib_srpt.c