]> www.infradead.org Git - users/dwmw2/linux.git/commit
usb: dwc2: drd: fix clock gating on USB role switch
authorTomas Marek <tomas.marek@elrest.cz>
Fri, 6 Sep 2024 05:50:25 +0000 (07:50 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 11 Sep 2024 13:35:33 +0000 (15:35 +0200)
commit2c6b6afa59e78bebcb65bbc8a76b3459f139547c
tree3b63832966f06ceac0e33f80a8d2f4bc66bcbb6c
parent1702bec4477cc7d31adb4a760d14d33fac928b7a
usb: dwc2: drd: fix clock gating on USB role switch

The dwc2_handle_usb_suspend_intr() function disables gadget clocks in USB
peripheral mode when no other power-down mode is available (introduced by
commit 0112b7ce68ea ("usb: dwc2: Update dwc2_handle_usb_suspend_intr function.")).
However, the dwc2_drd_role_sw_set() USB role update handler attempts to
read DWC2 registers if the USB role has changed while the USB is in suspend
mode (when the clocks are gated). This causes the system to hang.

Release the gadget clocks before handling the USB role update.

Fixes: 0112b7ce68ea ("usb: dwc2: Update dwc2_handle_usb_suspend_intr function.")
Cc: stable@vger.kernel.org
Signed-off-by: Tomas Marek <tomas.marek@elrest.cz>
Link: https://lore.kernel.org/r/20240906055025.25057-1-tomas.marek@elrest.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc2/drd.c