]> www.infradead.org Git - users/dwmw2/linux.git/commit
HID: vivaldi: fix sysfs attributes leak
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Sat, 26 Feb 2022 01:18:58 +0000 (17:18 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Mar 2022 13:15:56 +0000 (14:15 +0100)
commit2c6a75ea32f99ba4b315d7b58f579493d7ac2a9a
tree04dedcb7f6bee04a4843197afb6ab0a69a4692d0
parent2a18a38cbc3bc05b4aea1ef5eea14842972cbfa4
HID: vivaldi: fix sysfs attributes leak

[ Upstream commit cc71d37fd1f11e0495b1cf580909ebea37eaa886 ]

The driver creates the top row map sysfs attribute in input_configured()
method; unfortunately we do not have a callback that is executed when HID
interface is unbound, thus we are leaking these sysfs attributes, for
example when device is disconnected.

To fix it let's switch to managed version of adding sysfs attributes which
will ensure that they are destroyed when the driver is unbound.

Fixes: 14c9c014babe ("HID: add vivaldi HID driver")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Tested-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hid/hid-vivaldi.c