]> www.infradead.org Git - users/dwmw2/linux.git/commit
platform/x86: p2sb: Don't init until unassigned resources have been assigned
authorBen Fradella <bfradell@netapp.com>
Thu, 9 May 2024 16:49:34 +0000 (16:49 +0000)
committerHans de Goede <hdegoede@redhat.com>
Tue, 14 May 2024 09:43:39 +0000 (11:43 +0200)
commit2c6370e6607663fc5fa0fd9ed58e2e01014898c7
tree2e948229e0ce5cf5c1ece8068cafd20c330a80f6
parent7c4cd2afee68aea873c0c1fb729ba309f945510c
platform/x86: p2sb: Don't init until unassigned resources have been assigned

The P2SB could get an invalid BAR from the BIOS, and that won't be fixed
up until pcibios_assign_resources(), which is an fs_initcall().

- Move p2sb_fs_init() to an fs_initcall_sync(). This is still early
  enough to avoid a race with any dependent drivers.

- Add a check for IORESOURCE_UNSET in p2sb_valid_resource() to catch
  unset BARs going forward.

- Return error values from p2sb_fs_init() so that the 'initcall_debug'
  cmdline arg provides useful data.

Signed-off-by: Ben Fradella <bfradell@netapp.com>
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Klara Modin <klarasmodin@gmail.com>
Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Link: https://lore.kernel.org/r/20240509164905.41016-1-bcfradella@proton.me
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/p2sb.c