]> www.infradead.org Git - users/jedix/linux-maple.git/commit
can: m_can: m_can_close(): stop clocks after device has been shut down
authorMarc Kleine-Budde <mkl@pengutronix.de>
Mon, 9 Sep 2024 13:07:41 +0000 (15:07 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Thu, 12 Sep 2024 07:45:54 +0000 (09:45 +0200)
commit2c09b50efcad985cf920ca88baa9aa52b1999dcc
tree7e73c6d5a3138a77ef9255422cc6aba68f3c34fe
parent801ad2f87b0c6d0c34a75a4efd6bfd3a2d9f9298
can: m_can: m_can_close(): stop clocks after device has been shut down

After calling m_can_stop() an interrupt may be pending or NAPI might
still be executed. This means the driver might still touch registers
of the IP core after the clocks have been disabled. This is not good
practice and might lead to aborts depending on the SoC integration.

To avoid these potential problems, make m_can_close() symmetric to
m_can_open(), i.e. stop the clocks at the end, right before shutting
down the transceiver.

Fixes: e0d1f4816f2a ("can: m_can: add Bosch M_CAN controller support")
Link: https://patch.msgid.link/20240910-can-m_can-fix-ifup-v3-2-6c1720ba45ce@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/m_can/m_can.c