]> www.infradead.org Git - users/jedix/linux-maple.git/commit
KVM: VMX: hyper-v: Prevent impossible NULL pointer dereference in evmcs_load()
authorVitaly Kuznetsov <vkuznets@redhat.com>
Fri, 16 Aug 2024 13:01:24 +0000 (15:01 +0200)
committerSean Christopherson <seanjc@google.com>
Thu, 22 Aug 2024 18:35:18 +0000 (11:35 -0700)
commit2ab637df5f68d4e0cfa9becd10f43400aee785b3
treef4bbd96e359793ec9067b66ea3a357d1d1ffabda
parent41ab0d59faa9532bbd37c91b03a8e9fb0215d67c
KVM: VMX: hyper-v: Prevent impossible NULL pointer dereference in evmcs_load()

GCC 12.3.0 complains about a potential NULL pointer dereference in
evmcs_load() as hv_get_vp_assist_page() can return NULL. In fact, this
cannot happen because KVM verifies (hv_init_evmcs()) that every CPU has a
valid VP assist page and aborts enabling the feature otherwise. CPU
onlining path is also checked in vmx_hardware_enable().

To make the compiler happy and to future proof the code, add a KVM_BUG_ON()
sentinel. It doesn't seem to be possible (and logical) to observe
evmcs_load() happening without an active vCPU so it is presumed that
kvm_get_running_vcpu() can't return NULL.

No functional change intended.

Reported-by: Mirsad Todorovac <mtodorovac69@gmail.com>
Suggested-by: Sean Christopherson <seanjc@google.com>
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Link: https://lore.kernel.org/r/20240816130124.286226-1-vkuznets@redhat.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
arch/x86/kvm/vmx/vmx_onhyperv.h