]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ASoC: wm8904: Don't touch GPIO configs set to 0xFFFF
authorErnest Van Hoecke <ernest.vanhoecke@toradex.com>
Wed, 19 Mar 2025 14:20:56 +0000 (15:20 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 20 Mar 2025 12:42:28 +0000 (12:42 +0000)
commit2aa853248b6b6c76b9dd82353e45a4283f9c53ec
tree1caa203c86bc3e2d55fdeaa413537d475449ae9c
parentfd9582998b9a82ef53a34756de8a1fb86abac972
ASoC: wm8904: Don't touch GPIO configs set to 0xFFFF

When updating the GPIO registers, do nothing for all fields of gpio_cfg
that are "0xFFFF".

This "do nothing" flag used to be 0 to easily check whether the gpio_cfg
field was actually set inside pdata or left empty (default).

However, 0 is a valid configuration for these registers, while 0xFFFF is
not.

With this change, users can explicitly set them to 0.
Not setting gpio_cfg in the platform data will now lead to setting all
GPIO registers to 0 instead of leaving them unset.

No one is using this platform data with this codec.

The change gets the driver ready to properly set gpio_cfg from the DT.

Datasheet: https://statics.cirrus.com/pubs/proDatasheet/WM8904_Rev4.1.pdf
Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://patch.msgid.link/20250319142059.46692-3-francesco@dolcini.it
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm8904.c