]> www.infradead.org Git - users/jedix/linux-maple.git/commit
platform/x86: dcdbas: drop unneeded assignment in host_control_smi()
authorYang Li <yang.lee@linux.alibaba.com>
Wed, 12 May 2021 08:57:05 +0000 (16:57 +0800)
committerHans de Goede <hdegoede@redhat.com>
Thu, 20 May 2021 12:11:03 +0000 (14:11 +0200)
commit2a2fd02f2ddc3a574d01fff87f88c3c2de262e29
tree7931b18ecc97b7a254a3910ad7aff7077e77fa55
parent4bf9d1e4fdd15aeff13bd90adbb2057124c0ba49
platform/x86: dcdbas: drop unneeded assignment in host_control_smi()

Making '==' operation with ESM_STATUS_CMD_UNSUCCESSFUL directly
after calling the function inb() is more efficient, so assignment
to 'cmd_status' is redundant.

Eliminate the following clang_analyzer warning:
drivers/platform/x86/dell/dcdbas.c:397:11: warning: Although the value
stored to 'cmd_status' is used in the enclosing expression, the value
is never actually read from 'cmd_status'

No functional change.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Link: https://lore.kernel.org/r/1620809825-84105-1-git-send-email-yang.lee@linux.alibaba.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/dell/dcdbas.c