]> www.infradead.org Git - users/jedix/linux-maple.git/commit
squashfs: fix percpu address space issues in decompressor_multi_percpu.c
authorUros Bizjak <ubizjak@gmail.com>
Fri, 30 Aug 2024 09:10:50 +0000 (11:10 +0200)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 9 Sep 2024 23:47:41 +0000 (16:47 -0700)
commit2a1eb111d2859b13e5ff87baa6cfe343317b07bf
tree24e70687f6a58e0c23d840238faebb4edc4e0fd8
parent7b0a5b666959719043123a8882bae49ec699d948
squashfs: fix percpu address space issues in decompressor_multi_percpu.c

When strict percpu address space checks are enabled, then current direct
casts between the percpu address space and the generic address space fail
the compilation on x86_64 with:

decompressor_multi_percpu.c: In function `squashfs_decompressor_create':
decompressor_multi_percpu.c:49:16: error: cast to generic address space pointer from disjoint `__seg_gs' address space pointer

decompressor_multi_percpu.c: In function `squashfs_decompressor_destroy':
decompressor_multi_percpu.c:64:25: error: cast to `__seg_gs' address space pointer from disjoint generic address space pointer

decompressor_multi_percpu.c: In function `squashfs_decompress':
decompressor_multi_percpu.c:82:25: error: cast to `__seg_gs' address space pointer from disjoint generic address space pointer

Add intermediate casts to unsigned long, as advised in [1] and [2].

Side note: sparse still requires __force when casting from the percpu
address space, although the documentation [2] allows casts to unsigned
long without __force attribute.

Found by GCC's named address space checks.

There were no changes in the resulting object file.

[1] https://gcc.gnu.org/onlinedocs/gcc/Named-Address-Spaces.html#x86-Named-Address-Spaces
[2] https://sparse.docs.kernel.org/en/latest/annotations.html#address-space-name

Link: https://lkml.kernel.org/r/20240830091104.13049-1-ubizjak@gmail.com
Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Cc: Phillip Lougher <phillip@squashfs.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/squashfs/decompressor_multi_percpu.c