]> www.infradead.org Git - users/jedix/linux-maple.git/commit
wifi: wilc1000: Set MAC after operation mode
authorMarek Vasut <marex@denx.de>
Thu, 3 Oct 2024 13:24:17 +0000 (15:24 +0200)
committerKalle Valo <kvalo@kernel.org>
Thu, 17 Oct 2024 16:48:55 +0000 (19:48 +0300)
commit29dd3e48b9bd88bf65a1e760126fa18d1def7b30
tree3ddb49ea87828d2440f8a2ab59c6ef24cd8a2310
parent6dc94457725465407bdaae5455e7c0492dacdc4f
wifi: wilc1000: Set MAC after operation mode

It seems it is necessary to set WILC MAC address after operation mode,
otherwise the MAC address of the WILC MAC is reset back to what is in
nvmem. This causes a failure to associate with AP after the WILC MAC
address was overridden by userspace.

Test case:
"
ap$ cat << EOF > hostap.conf
interface=wlan0
ssid=ssid
hw_mode=g
channel=6
wpa=2
wpa_passphrase=pass
wpa_key_mgmt=WPA-PSK
EOF
ap$ hostapd -d hostap.conf
ap$ ifconfig wlan0 10.0.0.1
"

"
sta$ ifconfig wlan0 hw ether 00:11:22:33:44:55
sta$ wpa_supplicant -i wlan0 -c <(wpa_passphrase ssid pass)
sta$ ifconfig wlan0 10.0.0.2
sta$ ping 10.0.0.1 # fails without this patch
"

AP still indicates SA with original MAC address from nvmem without this patch:
"
nl80211: RX frame da=ff:ff:ff:ff:ff:ff sa=60:01:23:45:67:89 bssid=ff:ff:ff:ff:ff:ff ...
                                          ^^^^^^^^^^^^^^^^^
"

Fixes: 83d9b54ee5d4 ("wifi: wilc1000: read MAC address from fuse at probe")
Tested-by: Alexis Lothoré <alexis.lothore@bootlin.com>
Signed-off-by: Marek Vasut <marex@denx.de>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/20241003132504.52233-1-marex@denx.de
drivers/net/wireless/microchip/wilc1000/netdev.c