]> www.infradead.org Git - users/jedix/linux-maple.git/commit
bnx2x: byte swap rss_key to comply to Toeplitz specs
authorEric Dumazet <edumazet@google.com>
Wed, 23 Sep 2015 00:04:58 +0000 (17:04 -0700)
committerDan Duval <dan.duval@oracle.com>
Mon, 19 Oct 2015 22:15:45 +0000 (18:15 -0400)
commit29c4c8532b3c2063590335c1708d1b1042105613
tree9c7186020c38c608825e03ef8f946e98b0b5c14a
parent711bf6cef5c7cb5722b6a5292471404cf66c97a3
bnx2x: byte swap rss_key to comply to Toeplitz specs

Orabug: 22066196

After a good amount of debugging, I found bnx2x was byte swaping
the 40 bytes of rss_key.

If we byte swap the key, then bnx2x generates hashes matching
MSDN specs as documented in (Verifying the RSS Hash Calculation)

https://msdn.microsoft.com/en-us/library/windows/hardware/ff571021%
28v=vs.85%29.aspx

It is mostly a non issue, unless we want to mix different NIC
in a host, and want consistent hashing among all of them, ie
if they all use the boot time generated rss key, or if some application
is choosing specific tuple(s) so that incoming traffic lands into known
rx queue(s).

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit d682d2bdc30650a5c7ce9908ab83ab674b658744)

Signed-off-by: Dan Duval <dan.duval@oracle.com>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c