]> www.infradead.org Git - users/hch/dma-mapping.git/commit
drm/msm: Avoid NULL dereference in msm_disp_state_print_regs()
authorDouglas Anderson <dianders@chromium.org>
Mon, 14 Oct 2024 16:36:08 +0000 (09:36 -0700)
committerAbhinav Kumar <quic_abhinavk@quicinc.com>
Mon, 14 Oct 2024 20:16:17 +0000 (13:16 -0700)
commit293f53263266bc4340d777268ab4328a97f041fa
treeac745f7c73fe445dca441248707585d537ac1d6b
parent358b762400bd94db2a14a72dfcef74c7da6bd845
drm/msm: Avoid NULL dereference in msm_disp_state_print_regs()

If the allocation in msm_disp_state_dump_regs() failed then
`block->state` can be NULL. The msm_disp_state_print_regs() function
_does_ have code to try to handle it with:

  if (*reg)
    dump_addr = *reg;

...but since "dump_addr" is initialized to NULL the above is actually
a noop. The code then goes on to dereference `dump_addr`.

Make the function print "Registers not stored" when it sees a NULL to
solve this. Since we're touching the code, fix
msm_disp_state_print_regs() not to pointlessly take a double-pointer
and properly mark the pointer as `const`.

Fixes: 98659487b845 ("drm/msm: add support to take dpu snapshot")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/619657/
Link: https://lore.kernel.org/r/20241014093605.1.Ia1217cecec9ef09eb3c6d125360cc6c8574b0e73@changeid
Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c