]> www.infradead.org Git - users/dwmw2/qemu.git/commit
hw/i386/acpi: Set PCAT_COMPAT bit only when pic is not disabled
authorXiaoyao Li <xiaoyao.li@intel.com>
Wed, 3 Apr 2024 14:59:53 +0000 (10:59 -0400)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 23 Apr 2024 15:35:25 +0000 (17:35 +0200)
commit292dd287e78e0cbafde9d1522c729349d132d844
treed81d1316e03c2bfff0b4c53d50c29461bfc575bf
parentb07bf7b73fd02d24a7baa64a580f4974b86bbc86
hw/i386/acpi: Set PCAT_COMPAT bit only when pic is not disabled

A value 1 of PCAT_COMPAT (bit 0) of MADT.Flags indicates that the system
also has a PC-AT-compatible dual-8259 setup, i.e., the PIC.  When PIC
is not enabled (pic=off) for x86 machine, the PCAT_COMPAT bit needs to
be cleared.  The PIC probe should then print:

   [    0.155970] Using NULL legacy PIC

However, no such log printed in guest kernel unless PCAT_COMPAT is
cleared.

Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
Message-ID: <20240403145953.3082491-1-xiaoyao.li@intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/i386/acpi-common.c