]> www.infradead.org Git - users/jedix/linux-maple.git/commit
mailbox: pcc: Drop unnecessary endianness conversion of pcc_hdr.flags
authorSudeep Holla <sudeep.holla@arm.com>
Thu, 13 Mar 2025 15:28:49 +0000 (15:28 +0000)
committerJassi Brar <jassisinghbrar@gmail.com>
Thu, 27 Mar 2025 01:58:25 +0000 (20:58 -0500)
commit29237e6df42b08ccb4152121ec2c650fdae103e1
tree9f5854a28871cf81b7cf7672ca02d3862e4260a5
parentcf1338c0e02880cd235a4590eeb15e2039c873bc
mailbox: pcc: Drop unnecessary endianness conversion of pcc_hdr.flags

The Sparse static checker flags a type mismatch warning related to
endianness conversion:

  |  warning: incorrect type in argument 1 (different base types)
  |     expected restricted __le32 const [usertype] *p
  |     got unsigned int *

This is because an explicit endianness conversion (le32_to_cpu()) was
applied unnecessarily to a pcc_hdr.flags field that is already in
little-endian format.

The PCC driver is only enabled on little-endian kernels due to its
dependency on ACPI and EFI, making the explicit conversion unnecessary.

The redundant conversion occurs in pcc_chan_check_and_ack() for the
pcc_hdr.flags field. Drop this unnecessary endianness conversion of
pcc_hdr.flags.

Also drop the redundant PCC_ACK_FLAG_MASK definition and use the
more appropriate and already defined PCC_CMD_COMPLETION_NOTIFY.

Acked-by: Huisong Li <lihuisong@huawei.com>
Tested-by: Adam Young <admiyo@os.amperecomputing.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
drivers/mailbox/pcc.c
include/acpi/pcc.h