]> www.infradead.org Git - users/hch/configfs.git/commit
tcp: fix TFO SYN_RECV to not zero retrans_stamp with retransmits out
authorNeal Cardwell <ncardwell@google.com>
Tue, 1 Oct 2024 20:05:17 +0000 (20:05 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 3 Oct 2024 23:18:04 +0000 (16:18 -0700)
commit27c80efcc20486c82698f05f00e288b44513c86b
treec985d650a2f714f9b320250ab394ec3a29e6fbaf
parentb41b4cbd9655bcebcce941bef3601db8110335be
tcp: fix TFO SYN_RECV to not zero retrans_stamp with retransmits out

Fix tcp_rcv_synrecv_state_fastopen() to not zero retrans_stamp
if retransmits are outstanding.

tcp_fastopen_synack_timer() sets retrans_stamp, so typically we'll
need to zero retrans_stamp here to prevent spurious
retransmits_timed_out(). The logic to zero retrans_stamp is from this
2019 commit:

commit cd736d8b67fb ("tcp: fix retrans timestamp on passive Fast Open")

However, in the corner case where the ACK of our TFO SYNACK carried
some SACK blocks that caused us to enter TCP_CA_Recovery then that
non-zero retrans_stamp corresponds to the active fast recovery, and we
need to leave retrans_stamp with its current non-zero value, for
correct ETIMEDOUT and undo behavior.

Fixes: cd736d8b67fb ("tcp: fix retrans timestamp on passive Fast Open")
Signed-off-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: Yuchung Cheng <ycheng@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20241001200517.2756803-4-ncardwell.sw@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/tcp_input.c