]> www.infradead.org Git - users/jedix/linux-maple.git/commit
fpga: machxo2-spi: Return an error on failure
authorTom Rix <trix@redhat.com>
Tue, 10 Aug 2021 16:40:36 +0000 (09:40 -0700)
committerMoritz Fischer <mdf@kernel.org>
Wed, 11 Aug 2021 11:25:11 +0000 (04:25 -0700)
commit277c0dd93bf7271689078b2dc6fa4c2ec4ea550a
tree92c9854d5e624af720fff1cff4589a01a7c24d21
parent36a21d51725af2ce0700c6ebcb6b9594aac658a6
fpga: machxo2-spi: Return an error on failure

Earlier successes leave 'ret' in a non error state, so these errors are
not reported. Set ret to -EINVAL before going to the error handler.

This addresses two issues reported by smatch:
drivers/fpga/machxo2-spi.c:229 machxo2_write_init()
  warn: missing error code 'ret'

drivers/fpga/machxo2-spi.c:316 machxo2_write_complete()
  warn: missing error code 'ret'

[mdf@kernel.org: Reworded commit message]
Fixes: 88fb3a002330 ("fpga: lattice machxo2: Add Lattice MachXO2 support")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
drivers/fpga/machxo2-spi.c