]> www.infradead.org Git - users/hch/misc.git/commit
block: fix potential invalid pointer dereference in blk_add_partition
authorRiyan Dhiman <riyandhiman14@gmail.com>
Wed, 11 Sep 2024 13:29:54 +0000 (18:59 +0530)
committerJens Axboe <axboe@kernel.dk>
Thu, 12 Sep 2024 14:46:40 +0000 (08:46 -0600)
commit26e197b7f9240a4ac301dd0ad520c0c697c2ea7d
treeacc2440bb060663b939ddef9db8565a9b1df2888
parentcc089684664ebd379f1451aab65eb50f4008b381
block: fix potential invalid pointer dereference in blk_add_partition

The blk_add_partition() function initially used a single if-condition
(IS_ERR(part)) to check for errors when adding a partition. This was
modified to handle the specific case of -ENXIO separately, allowing the
function to proceed without logging the error in this case. However,
this change unintentionally left a path where md_autodetect_dev()
could be called without confirming that part is a valid pointer.

This commit separates the error handling logic by splitting the
initial if-condition, improving code readability and handling specific
error scenarios explicitly. The function now distinguishes the general
error case from -ENXIO without altering the existing behavior of
md_autodetect_dev() calls.

Fixes: b72053072c0b (block: allow partitions on host aware zone devices)
Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20240911132954.5874-1-riyandhiman14@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/partitions/core.c