]> www.infradead.org Git - users/jedix/linux-maple.git/commit
net: Fix TOCTOU issue in sk_is_readable()
authorMichal Luczaj <mhal@rbox.co>
Mon, 9 Jun 2025 17:08:03 +0000 (19:08 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 10 Jun 2025 22:31:28 +0000 (15:31 -0700)
commit2660a544fdc0940bba15f70508a46cf9a6491230
tree5bf9d18c3c58a5af969dd71fd5dd999ed50e6f51
parentdc9c67820f81ee0d34f9095195228fcb828315ff
net: Fix TOCTOU issue in sk_is_readable()

sk->sk_prot->sock_is_readable is a valid function pointer when sk resides
in a sockmap. After the last sk_psock_put() (which usually happens when
socket is removed from sockmap), sk->sk_prot gets restored and
sk->sk_prot->sock_is_readable becomes NULL.

This makes sk_is_readable() racy, if the value of sk->sk_prot is reloaded
after the initial check. Which in turn may lead to a null pointer
dereference.

Ensure the function pointer does not turn NULL after the check.

Fixes: 8934ce2fd081 ("bpf: sockmap redirect ingress support")
Suggested-by: Jakub Sitnicki <jakub@cloudflare.com>
Signed-off-by: Michal Luczaj <mhal@rbox.co>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Link: https://patch.msgid.link/20250609-skisreadable-toctou-v1-1-d0dfb2d62c37@rbox.co
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/net/sock.h