]> www.infradead.org Git - users/jedix/linux-maple.git/commit
cifs: fix integer overflow in match_server()
authorRoman Smirnov <r.smirnov@omp.ru>
Mon, 31 Mar 2025 08:22:49 +0000 (11:22 +0300)
committerSteve French <stfrench@microsoft.com>
Tue, 1 Apr 2025 02:10:17 +0000 (21:10 -0500)
commit2510859475d7f46ed7940db0853f3342bf1b65ee
tree7adb5aa648ddccfb8a9c5feb18b486144a4637d8
parent8b175e2e189673643bf5b996335f0430faddf953
cifs: fix integer overflow in match_server()

The echo_interval is not limited in any way during mounting,
which makes it possible to write a large number to it. This can
cause an overflow when multiplying ctx->echo_interval by HZ in
match_server().

Add constraints for echo_interval to smb3_fs_context_parse_param().

Found by Linux Verification Center (linuxtesting.org) with Svace.

Fixes: adfeb3e00e8e1 ("cifs: Make echo interval tunable")
Cc: stable@vger.kernel.org
Signed-off-by: Roman Smirnov <r.smirnov@omp.ru>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/fs_context.c