]> www.infradead.org Git - users/hch/misc.git/commit
__legitimize_mnt(): check for MNT_SYNC_UMOUNT should be under mount_lock
authorAl Viro <viro@zeniv.linux.org.uk>
Sun, 27 Apr 2025 19:41:51 +0000 (15:41 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Fri, 9 May 2025 22:02:12 +0000 (18:02 -0400)
commit250cf3693060a5f803c5f1ddc082bb06b16112a9
treec884726453d713884f9b471b56f8e6d83974f482
parent92a09c47464d040866cf2b4cd052bc60555185fb
__legitimize_mnt(): check for MNT_SYNC_UMOUNT should be under mount_lock

... or we risk stealing final mntput from sync umount - raising mnt_count
after umount(2) has verified that victim is not busy, but before it
has set MNT_SYNC_UMOUNT; in that case __legitimize_mnt() doesn't see
that it's safe to quietly undo mnt_count increment and leaves dropping
the reference to caller, where it'll be a full-blown mntput().

Check under mount_lock is needed; leaving the current one done before
taking that makes no sense - it's nowhere near common enough to bother
with.

Reviewed-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/namespace.c