]> www.infradead.org Git - nvme.git/commit
atm: Fix Use-After-Free in do_vcc_ioctl
authorHyunwoo Kim <v4bel@theori.io>
Sat, 9 Dec 2023 09:42:10 +0000 (04:42 -0500)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 12 Dec 2023 12:14:08 +0000 (13:14 +0100)
commit24e90b9e34f9e039f56b5f25f6e6eb92cdd8f4b3
tree8d978d27ee13819541f7e98293c33f0f792c38b3
parente307b5a845c5951dabafc48d00b6424ee64716c4
atm: Fix Use-After-Free in do_vcc_ioctl

Because do_vcc_ioctl() accesses sk->sk_receive_queue
without holding a sk->sk_receive_queue.lock, it can
cause a race with vcc_recvmsg().
A use-after-free for skb occurs with the following flow.
```
do_vcc_ioctl() -> skb_peek()
vcc_recvmsg() -> skb_recv_datagram() -> skb_free_datagram()
```
Add sk->sk_receive_queue.lock to do_vcc_ioctl() to fix this issue.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Hyunwoo Kim <v4bel@theori.io>
Link: https://lore.kernel.org/r/20231209094210.GA403126@v4bel-B760M-AORUS-ELITE-AX
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/atm/ioctl.c