]> www.infradead.org Git - users/jedix/linux-maple.git/commit
eeprom: ee1004: Call i2c_new_scanned_device to instantiate thermal sensor
authorGuenter Roeck <linux@roeck-us.net>
Sat, 29 Jun 2024 17:37:15 +0000 (10:37 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 4 Jul 2024 10:03:01 +0000 (12:03 +0200)
commit249b4deaff71cfc6ac9a8e436af876be6d84052b
tree4559b71dccd45302e9e0a11c080a54b991b21169
parent79d0df36b54179ac2192e56ad7fdb29c952f35e2
eeprom: ee1004: Call i2c_new_scanned_device to instantiate thermal sensor

Instantiating a device by calling i2c_new_client_device() assumes that the
device is not already instantiated. If that is not the case, it will return
an error and generate a misleading kernel log message.

i2c i2c-0: Failed to register i2c client jc42 at 0x18 (-16)

This can be reproduced by unloading the ee1004 driver and loading it again.

Avoid this by calling i2c_new_scanned_device() instead, which returns
silently if a device is already instantiated or does not exist.

Fixes: 393bd1000f81 ("eeprom: ee1004: add support for temperature sensor")
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Thomas Weißschuh <linux@weissschuh.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20240629173716.20389-1-linux@roeck-us.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/eeprom/ee1004.c