]> www.infradead.org Git - users/dwmw2/linux.git/commit
arm64: acpi: Harden get_cpu_for_acpi_id() against missing CPU entry
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Wed, 29 May 2024 13:34:39 +0000 (14:34 +0100)
committerCatalin Marinas <catalin.marinas@arm.com>
Fri, 28 Jun 2024 17:38:30 +0000 (18:38 +0100)
commit2488444274c70038eb6b686cba5f1ce48ebb9cdd
treebf492dcc7e6d47487b4bb6f29e14a9380d6af0ca
parent8d34b6f17b9ac93faa2791eb037dcb08bdf755de
arm64: acpi: Harden get_cpu_for_acpi_id() against missing CPU entry

In a review discussion of the changes to support vCPU hotplug where
a check was added on the GICC being enabled if was online, it was
noted that there is need to map back to the cpu and use that to index
into a cpumask. As such, a valid ID is needed.

If an MPIDR check fails in acpi_map_gic_cpu_interface() it is possible
for the entry in cpu_madt_gicc[cpu] == NULL.  This function would
then cause a NULL pointer dereference.   Whilst a path to trigger
this has not been established, harden this caller against the
possibility.

Reviewed-by: Gavin Shan <gshan@redhat.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20240529133446.28446-13-Jonathan.Cameron@huawei.com
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
arch/arm64/include/asm/acpi.h