]> www.infradead.org Git - users/dwmw2/linux.git/commit
netfilter: nf_tables: Fix potential data-race in __nft_flowtable_type_get()
authorZiyang Xuan <william.xuanziyang@huawei.com>
Wed, 3 Apr 2024 07:22:04 +0000 (15:22 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Apr 2024 14:19:38 +0000 (16:19 +0200)
commit2485bcfe05ee3cf9ca8923a94fa2e456924c79c8
tree7331c7e8eccd6c73de08a073e9a6c9d4d9d9805d
parentf7e3c88cc2a977c2b9a8aa52c1ce689e7b394e49
netfilter: nf_tables: Fix potential data-race in __nft_flowtable_type_get()

commit 24225011d81b471acc0e1e315b7d9905459a6304 upstream.

nft_unregister_flowtable_type() within nf_flow_inet_module_exit() can
concurrent with __nft_flowtable_type_get() within nf_tables_newflowtable().
And thhere is not any protection when iterate over nf_tables_flowtables
list in __nft_flowtable_type_get(). Therefore, there is pertential
data-race of nf_tables_flowtables list entry.

Use list_for_each_entry_rcu() to iterate over nf_tables_flowtables list
in __nft_flowtable_type_get(), and use rcu_read_lock() in the caller
nft_flowtable_type_get() to protect the entire type query process.

Fixes: 3b49e2e94e6e ("netfilter: nf_tables: add flow table netlink frontend")
Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/netfilter/nf_tables_api.c