]> www.infradead.org Git - users/jedix/linux-maple.git/commit
perf ftrace: Fix undefined behavior in cmp_profile_data()
authorKuan-Wei Chiu <visitorckw@gmail.com>
Mon, 9 Dec 2024 13:42:26 +0000 (21:42 +0800)
committerNamhyung Kim <namhyung@kernel.org>
Mon, 9 Dec 2024 21:54:08 +0000 (13:54 -0800)
commit246dfe3dc199246bd64635163115f2691623fc53
tree5bd0f5e4f408a698a01bab442b4bcc35538c7cac
parentc33aea446bf555ab2b4e06deb914ba8f87cdb068
perf ftrace: Fix undefined behavior in cmp_profile_data()

The comparison function cmp_profile_data() violates the C standard's
requirements for qsort() comparison functions, which mandate symmetry
and transitivity:

* Symmetry: If x < y, then y > x.
* Transitivity: If x < y and y < z, then x < z.

When v1 and v2 are equal, the function incorrectly returns 1, breaking
symmetry and transitivity. This causes undefined behavior, which can
lead to memory corruption in certain versions of glibc [1].

Fix the issue by returning 0 when v1 and v2 are equal, ensuring
compliance with the C standard and preventing undefined behavior.

Link: https://www.qualys.com/2024/01/30/qsort.txt
Fixes: 0f223813edd0 ("perf ftrace: Add 'profile' command")
Fixes: 74ae366c37b7 ("perf ftrace profile: Add -s/--sort option")
Cc: stable@vger.kernel.org
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Reviewed-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: jserv@ccns.ncku.edu.tw
Cc: chuang@cs.nycu.edu.tw
Link: https://lore.kernel.org/r/20241209134226.1939163-1-visitorckw@gmail.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/builtin-ftrace.c