]> www.infradead.org Git - users/willy/xarray.git/commit
igc: Fix missing time sync events
authorVinicius Costa Gomes <vinicius.gomes@intel.com>
Tue, 20 Feb 2024 23:57:10 +0000 (15:57 -0800)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Wed, 6 Mar 2024 17:17:35 +0000 (09:17 -0800)
commit244ae992e3e80e5c9c272c77324c831148457f95
tree74141a3e49ca0f43bdf0f35607b76d7a52f9a7cb
parentc055fc00c07be1f0df7375ab0036cebd1106ed38
igc: Fix missing time sync events

Fix "double" clearing of interrupts, which can cause external events
or timestamps to be missed.

The IGC_TSIRC Time Sync Interrupt Cause register can be cleared in two
ways, by either reading it or by writing '1' into the specific cause
bit. This is documented in section 8.16.1.

The following flow was used:
 1. read IGC_TSIRC into 'tsicr';
 2. handle the interrupts present in 'tsirc' and mark them in 'ack';
 3. write 'ack' into IGC_TSICR;

As both (1) and (3) will clear the interrupt cause, if the same
interrupt happens again between (1) and (3) it will be ignored,
causing events to be missed.

Remove the extra clear in (3).

Fixes: 2c344ae24501 ("igc: Add support for TX timestamping")
Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>
Tested-by: Kurt Kanzenbach <kurt@linutronix.de> # Intel i225
Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/igc/igc_main.c