]> www.infradead.org Git - users/jedix/linux-maple.git/commit
perf tools: Fix build-id event recording
authorNamhyung Kim <namhyung@kernel.org>
Wed, 27 Nov 2024 03:13:31 +0000 (19:13 -0800)
committerNamhyung Kim <namhyung@kernel.org>
Mon, 2 Dec 2024 20:36:20 +0000 (12:36 -0800)
commit23c44f6c83257923b179461694edcf62749bedd5
tree8e0f3bb9f50acae48f0562c5828eee5d49b3995e
parent40384c840ea1944d7c5a392e8975ed088ecf0b37
perf tools: Fix build-id event recording

The build-id events written at the end of the record session are broken
due to unexpected data.  The write_buildid() writes the fixed length
event first and then variable length filename.

But a recent change made it write more data in the padding area
accidentally.  So readers of the event see zero-filled data for the
next entry and treat it incorrectly.  This resulted in wrong kernel
symbols because the kernel DSO loaded a random vmlinux image in the
path as it didn't have a valid build-id.

Fixes: ae39ba16554e ("perf inject: Fix build ID injection")
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Reviewed-by: Ian Rogers <irogers@google.com>
Link: https://lore.kernel.org/r/Z0aRFFW9xMh3mqKB@google.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/util/build-id.c