]> www.infradead.org Git - users/dwmw2/linux.git/commit
SUNRPC: Address Kerberos performance/behavior regression
authorChuck Lever <chuck.lever@oracle.com>
Wed, 9 Jan 2019 15:04:57 +0000 (10:04 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 31 Jan 2019 07:15:35 +0000 (08:15 +0100)
commit237563f7d004f806d92cdda55f96e36ed97ce1b1
tree5280dfb708e833e809a96065c44a122b1f57d622
parentd1c7a6fea7a81dec9fcc5346bf3b879feedebba9
SUNRPC: Address Kerberos performance/behavior regression

[ Upstream commit deaa5c96c2f7e8b934088a1e70a0fe8797bd1149 ]

When using Kerberos with v4.20, I've observed frequent connection
loss on heavy workloads. I traced it down to the client underrunning
the GSS sequence number window -- NFS servers are required to drop
the RPC with the low sequence number, and also drop the connection
to signal that an RPC was dropped.

Bisected to commit 918f3c1fe83c ("SUNRPC: Improve latency for
interactive tasks").

I've got a one-line workaround for this issue, which is easy to
backport to v4.20 while a more permanent solution is being derived.
Essentially, tk_owner-based sorting is disabled for RPCs that carry
a GSS sequence number.

Fixes: 918f3c1fe83c ("SUNRPC: Improve latency for interactive ... ")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/sunrpc/xprt.c