]> www.infradead.org Git - users/jedix/linux-maple.git/commit
HID: intel-ish-hid: Fix build error for COMPILE_TEST
authorZhang Lixu <lixu.zhang@intel.com>
Thu, 23 May 2024 01:14:01 +0000 (09:14 +0800)
committerJiri Kosina <jkosina@suse.com>
Thu, 23 May 2024 12:12:48 +0000 (14:12 +0200)
commit2360497238261f17d4a3f6cbc02d6dbd8951c23c
treead8129a4ef79f894389b1f212442ae7b8411f49c
parent70ec81c2e2b4005465ad0d042e90b36087c36104
HID: intel-ish-hid: Fix build error for COMPILE_TEST

kernel test robot reported build error due to a pointer type mismatch:

  .../ishtp/loader.c:172:8: error: incompatible pointer types passing
  '__le64 *' (aka 'unsigned long long *') to parameter of type
  'dma_addr_t *' (aka 'unsigned int *')

The issue arises because the driver, which is primarily intended for
x86-64, is also built for i386 when COMPILE_TEST is enabled.

Resolve type mismatch by using a temporary dma_addr_t variable to hold
the DMA address. Populate this temporary variable in dma_alloc_coherent()
function, and then convert and store the address in the
fragment->fragment_tbl[i].ddr_adrs field in the correct format.
Similarly, convert the ddr_adrs field back to dma_addr_t when freeing
the DMA buffer with dma_free_coherent().

Fixes: 579a267e4617 ("HID: intel-ish-hid: Implement loading firmware from host feature")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202405201313.SAStVPrT-lkp@intel.com/
Signed-off-by: Zhang Lixu <lixu.zhang@intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/intel-ish-hid/ishtp/loader.c