]> www.infradead.org Git - users/jedix/linux-maple.git/commit
jump_label: Fix the fix, brown paper bags galore
authorPeter Zijlstra <peterz@infradead.org>
Wed, 31 Jul 2024 10:43:21 +0000 (12:43 +0200)
committerPeter Zijlstra <peterz@infradead.org>
Wed, 31 Jul 2024 10:57:39 +0000 (12:57 +0200)
commit224fa3552029a3d14bec7acf72ded8171d551b88
treeb841485555f36065017bb998f0e2629d3447289f
parent6623b0217d0c9bed80bfa43b778ce1c0eb03b497
jump_label: Fix the fix, brown paper bags galore

Per the example of:

  !atomic_cmpxchg(&key->enabled, 0, 1)

the inverse was written as:

  atomic_cmpxchg(&key->enabled, 1, 0)

except of course, that while !old is only true for old == 0, old is
true for everything except old == 0.

Fix it to read:

  atomic_cmpxchg(&key->enabled, 1, 0) == 1

such that only the 1->0 transition returns true and goes on to disable
the keys.

Fixes: 83ab38ef0a0b ("jump_label: Fix concurrency issues in static_key_slow_dec()")
Reported-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Darrick J. Wong <djwong@kernel.org>
Link: https://lkml.kernel.org/r/20240731105557.GY33588@noisy.programming.kicks-ass.net
kernel/jump_label.c