]> www.infradead.org Git - users/jedix/linux-maple.git/commit
mptcp: only inc MPJoinAckHMacFailure for HMAC failures
authorMatthieu Baerts (NGI0) <matttbe@kernel.org>
Mon, 7 Apr 2025 18:26:32 +0000 (20:26 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 8 Apr 2025 23:16:17 +0000 (16:16 -0700)
commit21c02e8272bc95ba0dd44943665c669029b42760
tree8614c5ac9b87948f1720d95782b6dddcb158d915
parent445e99bdf68d62cc8cd9c129ea177b2b847d654d
mptcp: only inc MPJoinAckHMacFailure for HMAC failures

Recently, during a debugging session using local MPTCP connections, I
noticed MPJoinAckHMacFailure was not zero on the server side. The
counter was in fact incremented when the PM rejected new subflows,
because the 'subflow' limit was reached.

The fix is easy, simply dissociating the two cases: only the HMAC
validation check should increase MPTCP_MIB_JOINACKMAC counter.

Fixes: 4cf8b7e48a09 ("subflow: introduce and use mptcp_can_accept_new_subflow()")
Cc: stable@vger.kernel.org
Reviewed-by: Geliang Tang <geliang@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250407-net-mptcp-hmac-failure-mib-v1-1-3c9ecd0a3a50@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mptcp/subflow.c