]> www.infradead.org Git - users/dwmw2/linux.git/commit
net: enetc: stop configuring pMAC in lockstep with eMAC
authorVladimir Oltean <vladimir.oltean@nxp.com>
Thu, 19 Jan 2023 16:04:29 +0000 (18:04 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 23 Jan 2023 13:13:09 +0000 (13:13 +0000)
commit219355f1b093526fc980a202e4d48e8469c9a29c
tree130768fac2836049b7eef47d58ceaa97cc7ca276
parent9c949e0b2f9ce2556287a82b5a95730e5cd370b5
net: enetc: stop configuring pMAC in lockstep with eMAC

The MWLM bit (MAC write lock-step mode) allows register writes to the
pMAC to be auto-performed whenever the corresponding eMAC register is
written by the driver. This allows their configuration to remain
in sync.

The driver has set this bit since the initial commit, but it doesn't do
anything, since the hardware feature doesn't work (and the bit has been
removed from more recent versions of the documentation).

The driver does attempt, more or less, to keep those MAC registers in
sync by writing the same value once to e.g. ENETC_PM0_CMD_CFG (eMAC) and
once to ENETC_PM1_CMD_CFG (pMAC). Because the lockstep feature doesn't
work, that's what it will stick to.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/enetc/enetc_hw.h
drivers/net/ethernet/freescale/enetc/enetc_pf.c