]> www.infradead.org Git - users/jedix/linux-maple.git/commit
btrfs: exit after state split error at btrfs_clear_extent_bit_changeset()
authorFilipe Manana <fdmanana@suse.com>
Wed, 9 Apr 2025 15:17:16 +0000 (16:17 +0100)
committerDavid Sterba <dsterba@suse.com>
Thu, 15 May 2025 12:30:50 +0000 (14:30 +0200)
commit2187540b6f4d92b4bf7622244dc2cbfa61ff1855
tree39bc33a2d58d7a62f7adbc66c9ae23cff27100ab
parentf389e7b982a14421dc6ec935552c39ea23da2f43
btrfs: exit after state split error at btrfs_clear_extent_bit_changeset()

If split_state() returned an error we call extent_io_tree_panic() which
will trigger a BUG() call. However if CONFIG_BUG is disabled, which is an
uncommon and exotic scenario, then we fallthrough and hit a use after free
when calling clear_state_bit() since the extent state record which the
local variable 'prealloc' points to was freed by split_state().

So jump to the label 'out' after calling extent_io_tree_panic() and set
the 'prealloc' pointer to NULL since split_state() has already freed it
when it hit an error.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/extent-io-tree.c