]> www.infradead.org Git - users/jedix/linux-maple.git/commit
phy: exynos5-usbdrd: fix EDS distribution tuning (gs101)
authorAndré Draszik <andre.draszik@linaro.org>
Fri, 6 Dec 2024 16:31:04 +0000 (16:31 +0000)
committerVinod Koul <vkoul@kernel.org>
Thu, 13 Feb 2025 17:12:52 +0000 (22:42 +0530)
commit21860f340ba76ee042e5431ff92537f89bc11476
tree44baacc415a625fa874c79468f11d8be99c07f05
parentee064390b82329df7fd8e0c48da03a8fee7d46ce
phy: exynos5-usbdrd: fix EDS distribution tuning (gs101)

This code's intention is to configure lane0 and lane2 tunings, but for
lane2 there is a typo and it ends up tuning something else.

Fix the typo, as it doesn't appear to make sense to apply different
tunings for lane0 vs lane2.

The same typo appears to exist in the bootloader, hence we restore the
original value in the typo'd registers as well. This can be removed
once / if the bootloader is updated.

Note that this is incorrect in the downstream driver as well - the
values had been copied from there.

Reviewed-by: Peter Griffin <peter.griffin@linaro.org>
Tested-by: Peter Griffin <peter.griffin@linaro.org>
Signed-off-by: André Draszik <andre.draszik@linaro.org>
Tested-by: Will McVicker <willmcvicker@google.com>
Link: https://lore.kernel.org/r/20241206-gs101-phy-lanes-orientation-phy-v4-4-f5961268b149@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/samsung/phy-exynos5-usbdrd.c