]> www.infradead.org Git - users/dwmw2/linux.git/commit
net: no longer reset transport_header in __netif_receive_skb_core()
authorEric Dumazet <edumazet@google.com>
Tue, 7 Jan 2025 14:43:42 +0000 (14:43 +0000)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 9 Jan 2025 12:18:41 +0000 (13:18 +0100)
commit2170a1f091486c2b5726a43c97a7d4b72073811c
tree2ee12ad3b54696832e14183ba287a609760fee61
parent9d8c354a56e9f6b420ad8eeee6db5c0d1b0ccc78
net: no longer reset transport_header in __netif_receive_skb_core()

In commit 66e4c8d95008 ("net: warn if transport header was not set")
I added a debug check in skb_transport_header() to detect
if a caller expects the transport_header to be set to a meaningful
value by a prior code path.

Unfortunately, __netif_receive_skb_core() resets the transport header
to the same value than the network header, defeating this check
in receive paths.

Pretending the transport and network headers are the same
is usually wrong.

This patch removes this reset for CONFIG_DEBUG_NET=y builds
to let fuzzers and CI find bugs.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250107144342.499759-1-edumazet@google.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/core/dev.c