]> www.infradead.org Git - users/dwmw2/linux.git/commit
smb: client: correctly handle ErrorContextData as a flexible array
authorLiang Jie <liangjie@lixiang.com>
Sat, 18 Jan 2025 12:35:28 +0000 (20:35 +0800)
committerSteve French <stfrench@microsoft.com>
Mon, 20 Jan 2025 01:34:00 +0000 (19:34 -0600)
commit215b7f9ecb8d7c14d56febdcdd246f3579c32aba
tree59b71030cc5fb77344399b39111679a36187d5b5
parent48aa99523e88e5792edc007e0c7f89faffacc5f7
smb: client: correctly handle ErrorContextData as a flexible array

The `smb2_symlink_err_rsp` structure was previously defined with
`ErrorContextData` as a single `__u8` byte. However, the `ErrorContextData`
field is intended to be a variable-length array based on `ErrorDataLength`.
This mismatch leads to incorrect pointer arithmetic and potential memory
access issues when processing error contexts.

Updates the `ErrorContextData` field to be a flexible array
(`__u8 ErrorContextData[]`). Additionally, it modifies the corresponding
casts in the `symlink_data()` function to properly handle the flexible
array, ensuring correct memory calculations and data handling.

These changes improve the robustness of SMB2 symlink error processing.

Signed-off-by: Liang Jie <liangjie@lixiang.com>
Suggested-by: Tom Talpey <tom@talpey.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/smb2file.c
fs/smb/client/smb2pdu.h